From: Dmitry Torokhov IRDA: smsc-ircc2 - do not over-use void * pointers, use specific types wherever possible. Signed-off-by: Dmitry Torokhov Cc: Jean Tourrilhes Signed-off-by: Andrew Morton --- drivers/net/irda/smsc-ircc2.c | 10 ++++------ 1 files changed, 4 insertions(+), 6 deletions(-) diff -puN drivers/net/irda/smsc-ircc2.c~smsc-ircc2-dont-use-void-where-specific-type-will-do drivers/net/irda/smsc-ircc2.c --- 25/drivers/net/irda/smsc-ircc2.c~smsc-ircc2-dont-use-void-where-specific-type-will-do 2005-06-24 23:45:26.000000000 -0700 +++ 25-akpm/drivers/net/irda/smsc-ircc2.c 2005-06-24 23:45:26.000000000 -0700 @@ -172,8 +172,8 @@ static int smsc_ircc_hard_xmit_sir(stru static int smsc_ircc_hard_xmit_fir(struct sk_buff *skb, struct net_device *dev); static void smsc_ircc_dma_xmit(struct smsc_ircc_cb *self, int bofs); static void smsc_ircc_dma_xmit_complete(struct smsc_ircc_cb *self); -static void smsc_ircc_change_speed(void *priv, u32 speed); -static void smsc_ircc_set_sir_speed(void *priv, u32 speed); +static void smsc_ircc_change_speed(struct smsc_ircc_cb *self, u32 speed); +static void smsc_ircc_set_sir_speed(struct smsc_ircc_cb *self, u32 speed); static irqreturn_t smsc_ircc_interrupt(int irq, void *dev_id, struct pt_regs *regs); static irqreturn_t smsc_ircc_interrupt_sir(struct net_device *dev); static void smsc_ircc_sir_start(struct smsc_ircc_cb *self); @@ -966,9 +966,8 @@ static void smsc_ircc_fir_stop(struct sm * This function *must* be called with spinlock held, because it may * be called from the irq handler. - Jean II */ -static void smsc_ircc_change_speed(void *priv, u32 speed) +static void smsc_ircc_change_speed(struct smsc_ircc_cb *self, u32 speed) { - struct smsc_ircc_cb *self = (struct smsc_ircc_cb *) priv; struct net_device *dev; int last_speed_was_sir; @@ -1033,9 +1032,8 @@ static void smsc_ircc_change_speed(void * Set speed of IrDA port to specified baudrate * */ -void smsc_ircc_set_sir_speed(void *priv, __u32 speed) +void smsc_ircc_set_sir_speed(struct smsc_ircc_cb *self, __u32 speed) { - struct smsc_ircc_cb *self = (struct smsc_ircc_cb *) priv; int iobase; int fcr; /* FIFO control reg */ int lcr; /* Line control reg */ _